Skip to content

Comments

Remove duplicated configs#1616

Merged
hmstepanek merged 2 commits intodevelop-hybrid-core-tracingfrom
remove-duplicated-configs
Jan 2, 2026
Merged

Remove duplicated configs#1616
hmstepanek merged 2 commits intodevelop-hybrid-core-tracingfrom
remove-duplicated-configs

Conversation

@hmstepanek
Copy link
Contributor

Overview

Remove duplicate distributed_tracing.sampler.full_granularity.<section> configuration paths and only support distributed_tracing.sampler.<section> paths.

@hmstepanek hmstepanek requested a review from a team as a code owner December 24, 2025 22:04
@hmstepanek hmstepanek changed the base branch from main to develop-hybrid-core-tracing December 24, 2025 22:05
@github-actions
Copy link

github-actions bot commented Dec 24, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 0.87s
✅ MARKDOWN markdownlint 7 0 0 0 1.33s
✅ PYTHON ruff 976 0 0 0 0.92s
✅ PYTHON ruff-format 976 0 0 0 0.38s
✅ YAML prettier 15 0 0 0 1.46s
✅ YAML v8r 15 0 0 6.32s
✅ YAML yamllint 15 0 0 0.69s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Dec 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.04%. Comparing base (d71dad1) to head (7d48523).
⚠️ Report is 2 commits behind head on develop-hybrid-core-tracing.

Files with missing lines Patch % Lines
newrelic/core/samplers/sampler_proxy.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           develop-hybrid-core-tracing    #1616      +/-   ##
===============================================================
+ Coverage                        79.93%   80.04%   +0.10%     
===============================================================
  Files                              213      213              
  Lines                            25168    25171       +3     
  Branches                          4001     4007       +6     
===============================================================
+ Hits                             20117    20147      +30     
+ Misses                            3622     3591      -31     
- Partials                          1429     1433       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmstepanek hmstepanek force-pushed the remove-duplicated-configs branch 2 times, most recently from 7dc8c5c to d62cebe Compare December 29, 2025 21:17
@hmstepanek hmstepanek force-pushed the remove-duplicated-configs branch from 6b01b8a to 58ecf41 Compare December 29, 2025 21:19
@hmstepanek hmstepanek merged commit 1e115d3 into develop-hybrid-core-tracing Jan 2, 2026
54 of 61 checks passed
@hmstepanek hmstepanek deleted the remove-duplicated-configs branch January 2, 2026 23:12
@mergify mergify bot removed the tests-failing Tests failing in CI. label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants